fix: incompatibility with rstest parametrized tests - #132
Open
Adam Cooper (super-cooper) wants to merge 1 commit into
Open
Adam Cooper (super-cooper) wants to merge 1 commit into
Adam Cooper (super-cooper) wants to merge 1 commit into
Conversation
rstest generates parametrized tests (`#[case]`) as one helper function that is called by each test generated for the different cases. Because of this, injectorpp's internal static counter is reused between these test cases. The same would hold true for an injector created in any helper function. This patch resets the static counter to zero when the verifier is dropped so it can be reused in these scenarios. Additionally: * rstest is added as a dev dependency * An new test validates the desired behavior
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Thanks for making the change. Would you mind taking a look at the failed tests? Looks like rstest still failed with the change. |
Author
|
It looks like the lint regression is in an untouched portion of the file that I had edited. I fixed it, but this may not be desirable for you as part of this patch. Regarding the test failures:
I would like to fix these issues, but unfortunately, these two platforms have proven very difficult to iterate on. Do the maintainers have any solutions for this that I could use? |
Contributor
|
Thanks! Let me take a look to see if there's any way to get it done. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rstest generates parametrized tests (
#[case]) as one helper function that is called by each test generated for the different cases. Because of this, injectorpp's internal static counter is reused between these test cases. The same would hold true for an injector created in any helper function.This patch resets the static counter to zero when the verifier is dropped so it can be reused in these scenarios.
Additionally: