Handle mach_vm* functions return to debug failures - #133
Merged
Jingyu Ma (mazong1123) merged 2 commits intoAug 7, 2026
Merged
Conversation
Luciano Almeida (lucianopa-msft)
force-pushed
the
lucianopa/handle-err
branch
from
July 6, 2026 17:39
9a1d8e5 to
e0550f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just handles a failure result in
mach_vmfunction for MacOS where we've seen some cases where this may fail (still investigating) but not handling this failure would cause a segmentation fault so this would be more helpful for debug/report to panic on the source of failure than to ignore that it fails and then trying to access that memory ininject_asm_code->ptr::copy_nonoverlapping.