Makefile: drop stale grpc@v1.59.0 pin from bootstrap target#445
Merged
raghavendra-nataraj merged 1 commit intoJul 23, 2026
Merged
Conversation
The `bootstrap` target ran `go get -u google.golang.org/grpc@v1.59.0`, pinning grpc to v1.59.0. That pin was added in #367 when grpc was at v1.59.0 and never updated after go.mod moved to v1.82.1. Because `bootstrap` is a prerequisite of `generate`/`pipeline`, running either target downgrades the module's grpc back to v1.59.0 (re-introducing already-remediated CVEs) and `gen.sh`'s trailing `go mod tidy` persists the downgrade into go.mod/go.sum. Proto generation does not need the grpc module fetched: rpc/gen_proto.sh emits code via `--go_out=plugins=grpc:`, whose grpc plugin ships inside protoc-gen-go@v1.3.2. The grpc runtime version is governed entirely by go.mod. Removing the line leaves bootstrap installing only protoc-gen-go and keeps grpc at the go.mod-selected v1.82.1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4a902de7-e15e-494c-b590-1f9e94a5fadd
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
rjaini
approved these changes
Jul 23, 2026
madhanrm
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the stale
go get -u google.golang.org/grpc@v1.59.0line from thebootstraptarget in the Makefile.Why
bootstrapis a prerequisite of thegenerateandpipelinetargets.go.modmoved to v1.82.1.make generate/make pipelinetherefore downgrades the module's grpc back to v1.59.0 — re-introducing already-remediated CVEs — andgen.sh's trailinggo mod tidypersists that downgrade intogo.mod/go.sum.Why removal is safe
rpc/gen_proto.shgenerates via--go_out=plugins=grpc:, whose grpc plugin ships insideprotoc-gen-go@v1.3.2(installed by the samebootstraptarget).go.mod. After this change,bootstrapinstalls onlyprotoc-gen-goand grpc stays at the go.mod-selected v1.82.1.Diff
bootstrap: - GOOS="linux" go get -u google.golang.org/grpc@v1.59.0 GOOS="linux" go install github.com/golang/protobuf/protoc-gen-go@v1.3.2