Skip to content

CI: Introduce basic OpenVMM testing and utilize reusable actions - #109

Merged
Maheer Aeron (maheeraeron) merged 24 commits into
microsoft:mainfrom
maheeraeron:user/maheeraeron/use-devops
Sep 11, 2026
Merged

CI: Introduce basic OpenVMM testing and utilize reusable actions#109
Maheer Aeron (maheeraeron) merged 24 commits into
microsoft:mainfrom
maheeraeron:user/maheeraeron/use-devops

Conversation

@maheeraeron

@maheeraeron Maheer Aeron (maheeraeron) commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Adds basic Ubuntu boot testing with OpenVMM from the latest successful main run, and also organizes certain steps into github actions. Furthermore, external github actions are now pinned to a commit SHA.

The OpenVMM tests are limited to X64 for now. ARM64 support will come in the future.

@maheeraeron
Maheer Aeron (maheeraeron) marked this pull request as ready for review September 3, 2026 21:25
Comment thread .github/workflows/openvmm-test.yml Outdated

@mebersol Mike Ebersol (mebersol) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Copilot] Overall this is a good direction — SHA-pinning the third-party actions, fail-fast: false, if-no-files-found: error, and the log-upload step are all real improvements, and adding -legacy-${{ matrix.c-core }} to the artifact name fixes a latent duplicate-artifact-name collision in the old workflow.

Leaving four comments: one blocking (the fork/secrets issue on openvmm-test-x64, which also gates release), and three smaller ones around consistency and discoverability.

Comment thread .github/workflows/platform-ci.yml
Comment thread .pytool/CISettings.py
Comment thread .github/workflows/openvmm-test.yml Outdated
Comment thread .github/workflows/platform-ci.yml
@maheeraeron Maheer Aeron (maheeraeron) changed the title CI: Use mu_devops workflows and simplify yaml CI: Introduce basic OpenVMM testing and utilize reusable actions Sep 8, 2026
Comment thread .github/workflows/platform-ci.yml Outdated
Comment thread MsvmPkg/Docs/BUILDING.md

@mebersol Mike Ebersol (mebersol) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Copilot] Re-reviewed at b5b0019. All four comments from my first pass are properly addressed — dropping the PAT in favour of ${{ github.token }} is a better answer than the fork guard I suggested, and replacing the magic -ne 6 with -eq 0 is the right call given needs: build already requires every matrix leg to pass. The run-selection loop that skips OpenVMM runs with expired or missing artifacts, normalize_bundle_file, and adding dependabot.yml alongside the SHA pinning are all good additions.

Three comments on the new iteration. The OFFICIAL_BUILD one is the only one I'd want resolved before merge — silent loss of the official-build flag on main is the kind of thing that stays invisible for months.

Comment thread .github/workflows/platform-ci.yml
Comment thread .github/actions/openvmm-test/action.yml
Comment thread .github/workflows/platform-ci.yml
@maheeraeron
Maheer Aeron (maheeraeron) merged commit 8848e1d into microsoft:main Sep 11, 2026
14 checks passed
@maheeraeron
Maheer Aeron (maheeraeron) deleted the user/maheeraeron/use-devops branch September 11, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants