Skip to content

ci: let a cancellation reach the runtime adapter's suite #1004

Open

Description

#975 made the Linux steps that run test-microvm and the benchmarks exec their harness, so that the runner's SIGINT and SIGTERM reach it (#946).

The runtime adapter's Linux step in run-nvx-microvm-tests.yml (nvx.py test-runtime-adapter; earlier, cargo test) still runs in Bash's foreground. Its command doesn't pass a cancellation on to cargo test and the test binaries, so their VMs run until the runner's orphan cleanup.

To fix: exec the command, and have it forward SIGINT and SIGTERM to cargo test's process group, then wait for it.

Found while validating #963. Related to #833.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions