Skip to content

[Telemetry] Prevent crashes in shell-less containers #32226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmehta001 merged 3 commits into from
Aug 24, 2026
Merged

[Telemetry] Prevent crashes in shell-less containers #32226

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b512d3b
Prevent telemetry crash in shell-less containers
bmehta001 Aug 24, 2026
43b6634
Align telemetry cleanup with upstream ownership fix
bmehta001 Aug 24, 2026
85e0678
Use unique ownership in telemetry compatibility fix
bmehta001 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmake/patches/cpp_client_telemetry/cpp_client_telemetry.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,19 @@
{
LOG_ERROR("Unable to allocate memory to pack EventProperties");

--- a/lib/pal/posix/sysinfo_sources.cpp
+++ b/lib/pal/posix/sysinfo_sources.cpp
@@ -114,7 +114,8 @@
{
std::array<char, 128> buffer;
std::string result;
- std::shared_ptr<FILE> pipe(popen(cmd, "r"), pclose);
+ auto close_pipe = [](FILE* file) { pclose(file); };
+ std::unique_ptr<FILE, decltype(close_pipe)> pipe(popen(cmd, "r"), close_pipe);
if (!pipe)
{
// throw std::runtime_error("popen() failed!");

--- a/lib/CMakeLists.txt
+++ b/lib/CMakeLists.txt
@@ -7,7 +7,7 @@
Expand Down
Loading