Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(scripts): exclude auto-maintained-file-only commits from generated changelogs #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
fix(scripts): exclude auto-maintained-file-only commits from generated changelogs #490
Changes from all commits
c923f234a30857356a5d118736f3File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The advertised mixed-file case is not covered — Testing · Medium · High
The PR contract says a commit that touches
README.mdandsrc/must be kept, but this fixture models those as two separate commits: one source-only record and one README-only record. A regression from the current all-files predicate to an any-file exclusion would therefore still satisfy every new assertion while dropping a real package change from its changelog.Direction: add one commit record whose file block contains both
crates/pkg/README.mdandcrates/pkg/src/lib.rs, and assert that commit's subject is retained.Done when: that mixed-file test fails if the filter excludes a record merely because any auto-maintained path is present.
Uh oh!
There was an error while loading. Please reload this page.