Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 95a89ae9-292f-4300-878a-ac61ade1eb7b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 95a89ae9-292f-4300-878a-ac61ade1eb7b
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 473 473
Lines 45493 45493
=======================================
Hits 45493 45493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
martintmk
left a comment
There was a problem hiding this comment.
Posted by an AI agent
Two non-blocking stabilization-documentation findings remain.
Coverage: Complete current-head review covered API design, correctness, tests, performance, naming, telemetry, resilience, consistency, public API, and public documentation. This is a documentation-only change; the package build passed and no runtime or test behavior changed.
Vote: Not requested because the authenticated reviewer owns this PR.
| at usage sites. Removing the current requirement changes guarantees available to | ||
| downstream callers. The stable contract should not impose cross-thread execution | ||
| when an implementation and its caller are both thread-local. | ||
| - Select the concrete error boundary. The associated error type and the crate's |
There was a problem hiding this comment.
Posted by an AI agent · Non-blocking
The stable error boundary does not cover recovery classification
Problem
The stabilization decisions cover the associated error type and wrapper composition, but do not decide whether transient/unavailable classifications and retry-delay hints must survive conversion into the crate error.
Why this matters
Once the traits stabilize, adding a required recovery contract can become a breaking change, while callers cannot reliably drive retries or circuit breakers if wrapping erases that information.
Suggested fix
Add recovery classification and preservation to the error-boundary checklist, including an explicit decision if this lower-level crate intentionally leaves classification to adapters.
|
|
||
| ## Pending review | ||
|
|
||
| - [ ] Review the trait shape against `arty_io`, TCP, and fetch use cases. |
There was a problem hiding this comment.
Posted by an AI agent · Non-blocking
The arty_io review dependency is not identifiable
Problem
The pending checklist requires review against arty_io, but that identifier has no definition or link in this repository.
Why this matters
A future stabilizer cannot determine which consumer and requirements must be checked before completing this item.
Suggested fix
Use the canonical project/package name and add a reference or short identifying description.
Summary
Adds pending stabilization notes for the
bytesbuf_iocrate based on O365 Core work item 7688115. The notes record the proposed owned-buffer I/O boundary, current and proposed trait requirements, read and write semantics, ecosystem adapter strategy, and unresolved review items. Also adds an emptydocs/DESIGN.mdplaceholder.Validation
just package=bytesbuf_io formatjust package=bytesbuf_io readmecargo check -p bytesbuf_io --all-featurescargo build -p bytesbuf_io --all-featurescargo test -p bytesbuf_io --all-featuresgit diff --checkLocal spellcheck was attempted, but the installed
cargo-spellcheckprocess exits during startup on this machine. The GitHub spell-check job passed.