feat(ui-mode): update individual snapshots - #42421
feat(ui-mode): update individual snapshots#42421Devin Rousso (dcrousso) wants to merge 1 commit into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 CI is clear — the one failure is a pre-existing flakeThe single failure, DetailsOverall: nothing in this diff reaches the failing paths. The PR adds a "Save actual as expected" button in trace-viewer plus an Pre-existing flake / infra
Not failures (no action)
I'm a first pass, not the final word — but I couldn't find any failure that points back at this change. Triaged by the Playwright bot - agent run |
|
Requesting a demo of this one, unclear from the code what is happening and which scenarios this supports. |
c38f708 to
7308b9e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| </div>; | ||
| }; | ||
|
|
||
| function UpdateSnapshotButton({ actualPath, expectedPath, onUpdateSnapshot }: { |
There was a problem hiding this comment.
I think we agreed to flash a green checkmark instead of updating the text?
| />; | ||
| }; | ||
|
|
||
| function addLocalAttachmentPaths(model: TraceModel, result: reporterTypes.TestResult) { |
There was a problem hiding this comment.
What's going on here? Why don't we have correct attachment paths? Why do we only call before a single setModel(), and not before all the others?
There was a problem hiding this comment.
ive reworked this
reviewing image diffs currently requires rerunning tests with snapshot updates enabled add a button for each diff that copies the actual image over the expected snapshot
7308b9e to
739adf5
Compare
Test results for "tests 1"5 flaky51277 passed, 1241 skipped Merge workflow run. |
Test results for "MCP"8305 passed, 1367 skipped Merge workflow run. |


reviewing image diffs currently requires rerunning tests with snapshot updates enabled
add a button for each diff that copies the actual image over the expected snapshot
fixes #42393