Skip to content

fix(web): make sortable grid column headers keyboard accessible #42471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Miodrag Obradovic (Kjubikstronk) wants to merge 1 commit into
base: main
Choose a base branch
from
+40 −4
Open

fix(web): make sortable grid column headers keyboard accessible #42471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/web/src/components/gridView.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,20 @@
white-space: nowrap;
}

.grid-view-header-cell-button {
all: unset;
display: flex;
align-items: center;
flex: auto;
overflow: hidden;
cursor: pointer;
}

.grid-view-header-cell-button:focus-visible {
outline: 1px solid var(--vscode-focusBorder);
outline-offset: -1px;
}

.grid-view-header-cell-title {
overflow: hidden;
text-overflow: ellipsis;
Expand Down
15 changes: 11 additions & 4 deletions packages/web/src/components/gridView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,24 @@ export function GridView<T>(model: GridViewProps<T>) {
<div className='vbox'>
<div className='grid-view-header'>
{model.columns.map((column, i) => {
const title = <>
<span className='grid-view-header-cell-title'>{model.columnTitle(column)}</span>
<span className='codicon codicon-triangle-up' />
<span className='codicon codicon-triangle-down' />
</>;
return <div
key={model.columnTitle(column)}
className={'grid-view-header-cell ' + sortingHeader(column, model.sorting)}
style={{
width: i < model.columns.length - 1 ? model.columnWidths.get(column) : undefined,
}}
onClick={() => model.setSorting && toggleSorting(column)}
>
<span className='grid-view-header-cell-title'>{model.columnTitle(column)}</span>
<span className='codicon codicon-triangle-up' />
<span className='codicon codicon-triangle-down' />
{model.setSorting ? <button
className='grid-view-header-cell-button'
onClick={() => toggleSorting(column)}
>
{title}
</button> : title}
</div>;
})}
</div>
Expand Down
15 changes: 15 additions & 0 deletions tests/library/trace-viewer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,21 @@ test('should have network requests', async ({ showTraceViewer }) => {
await expect(traceViewer.networkRequests.filter({ hasText: '404GET404text' })).toHaveCSS('background-color', 'rgb(242, 222, 222)');
});

test('should sort network columns from the keyboard', async ({ showTraceViewer }) => {
const traceViewer = await showTraceViewer(traceFile);
await traceViewer.selectAction('Navigate');
await traceViewer.showNetworkTab();

const nameColumn = traceViewer.page.getByRole('button', { name: 'Name', exact: true });
await expect(nameColumn).toBeVisible();

await nameColumn.focus();
await expect(nameColumn).toBeFocused();

await nameColumn.press('Enter');
await expect(traceViewer.networkRequests.first()).toContainText('404');
});

test('should attribute network requests to service workers', async ({ runAndTrace, page, context, server, browserName }) => {
test.skip(browserName !== 'chromium', 'Service worker requests are only reported in Chromium');
const traceViewer = await runAndTrace(async () => {
Expand Down