Repository navigation
Conversation
Let the vcpkg toolchain communicate iOS through CMAKE_SYSTEM_NAME instead of passing upstream's deprecated BUILD_IOS compatibility option. Files changed: - ports/cpp-client-telemetry/portfile.cmake - ports/cpp-client-telemetry/vcpkg.json - versions/baseline.json - versions/c-/cpp-client-telemetry.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 037b338a-b5c0-4989-b9d3-36681fb822f5
Member
|
This seems a reasonable change to me but PR closed now so 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the follow-up noted in #53679.
The vcpkg toolchain already sets
CMAKE_SYSTEM_NAME=iOS, which cpp-client-telemetry 3.10.240.1 uses for iOS targeting. Stop passing the deprecatedBUILD_IOScompatibility option and increment the port revision.The separate upstream SQLite target warning is addressed by microsoft/cpp_client_telemetry#1532 and will be included in a future source release.
Validation:
vcpkg format-manifest ports/cpp-client-telemetry/vcpkg.jsonvcpkg x-add-version cpp-client-telemetry --overwrite-version