Repository navigation
Fix preview startup when the WebSocket port is occupied - #886
Closed
Mikhail Yaskou (mikhail-yaskou) wants to merge 1 commit into
Closed
Mikhail Yaskou (mikhail-yaskou) wants to merge 1 commit into
Mikhail Yaskou (mikhail-yaskou) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the WebSocket port is occupied at startup,
_handleWSErrorcreates a replacementWSServerWithOriginCheckwithout registering itsconnection,error, orlisteninghandlers. The replacement can bind successfully, but the original startup promise never settles, soServerGrouping.openServer()never calls_connected()and Show Preview never opens. A second collision can also emit an unhandled error. TheEADDRNOTAVAILbranch has the same missing handlers.Restart through
_startWSServer(basePath)in both recoverable error branches and chain its result to the original promise. Every bind attempt then registers the original handlers, and successful startup or failure propagates back to the caller.Validation on Linux against the actual bundled
_startWSServermethod from Live Preview 0.4.20, using real TCP blockers and a real WebSocket client: