Chat: distinguish question carousel link states - #335461
Open
Lee Murray (mrleemurray) wants to merge 2 commits into
Open
Chat: distinguish question carousel link states#335461Lee Murray (mrleemurray) wants to merge 2 commits into
Lee Murray (mrleemurray) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Lee Murray (mrleemurray)
September 10, 2026 12:14
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The active-state test remains under hover and cannot independently detect an active-style regression.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds carousel-scoped visual states for hovered, pressed, and keyboard-focused links.
Changes:
- Adds stronger hover/active underlines.
- Adds theme-aware keyboard focus outlines.
- Adds Playwright coverage across four theme variants.
File summaries
| File | Description |
|---|---|
chatQuestionCarousel.css |
Defines carousel link interaction styling. |
chatQuestionCarouselLinks.spec.ts |
Tests link styles across themes and states. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat question carousel links now react visibly to hover and press across Light 2026, Dark 2026, and high-contrast themes without changing link styling elsewhere.
Changes
Validation
origin/mainbaseline.Fixes #334651
Before / After
Captured from the real
chat/chatQuestionCarousel/MarkdownLinkswidget fixture in Chrome 153 with the same 720×640 viewport, 1× device scale, 100% zoom, interaction target, and 416×314 fixture crop. Resting renders are byte-for-byte unchanged.Light 2026
Dark 2026
Light High Contrast
Dark High Contrast