Skip to content

Add Agents Window taskbar shortcut and icons - #335947

Open
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
mainfrom
agents/create-pr-same-changes-335333
Open

Add Agents Window taskbar shortcut and icons#335947
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
mainfrom
agents/create-pr-same-changes-335333

Conversation

@dmitrivMS

Copy link
Copy Markdown
Collaborator
  • Add an Agents Window task to the Windows taskbar jump list
  • Launch it through the existing --agents mode
  • Use the distro-mixed sessions.ico asset for the jump-list task and resulting Windows taskbar button, so Stable, Insiders, and Exploration receive matching product-quality branding
  • Expose each native CodeWindow icon path through generic opened-window metadata
  • Have Switch Window render the icon advertised by the window, preserving existing file and workspace icons when a native icon is not provided

Screenshots

image image

Related issues

Fixes #335321
Fixes #315734
Fixes #315935

Reapply the exact changes from #335333 after their revert in #335597.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Update or recreate reused windows when their kind changes so the Agents icon remains correct.

Review tier: Lite (auto)
Findings: None

Note

Copilot is running an experiment and ran this review at Lite.

What changed in this PR

Adds Windows Agents Window taskbar access and propagates native window icons to Switch Window.

Changes:

  • Adds the --agents jump-list task and packages sessions.ico.
  • Applies Agents branding to native Windows windows.
  • Exposes native icons in Switch Window.
  • Filters Agents windows from recent workspaces.

A reused CodeWindow can switch to Agents mode without updating its icon, leaving the normal VS Code branding visible.

File Reviewed changes
src/​vs/​workbench/​electron-browser/​actions/​windowActions.ts Renders advertised native icons.
src/​vs/​platform/​workspaces/​electron-main/​workspacesHistoryMainService.ts Adds the jump-list task and filters Agents recents.
src/​vs/​platform/​windows/​test/​electron-main/​windowsFinder.test.ts Updates the native window test mock.
src/​vs/​platform/​windows/​electron-main/​windowImpl.ts Assigns the Agents Window icon.
src/​vs/​platform/​window/​electron-main/​window.ts Exposes native icon metadata.
src/​vs/​platform/​window/​common/​window.ts Adds icon metadata to opened windows.
src/​vs/​platform/​native/​electron-main/​nativeHostMainService.ts Publishes native icon paths.
build/​gulpfile.vscode.ts Packages sessions.ico for Windows builds.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dmitrivMS Dmitriy Vasyura (dmitrivMS) added windows VS Code on Windows issues agents-window workbench-os-integration Native OS integration issues labels Sep 12, 2026
@dmitrivMS Dmitriy Vasyura (dmitrivMS) added this to the 1.139.0 milestone Sep 12, 2026
@dmitrivMS
Dmitriy Vasyura (dmitrivMS) marked this pull request as ready for review September 12, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents-window windows VS Code on Windows issues workbench-os-integration Native OS integration issues

Projects

None yet

2 participants