Fix configuration elevation validation for standard flow#6307
Open
JohnMcPMS wants to merge 3 commits into
Open
Fix configuration elevation validation for standard flow#6307JohnMcPMS wants to merge 3 commits into
JohnMcPMS wants to merge 3 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
As described in the issue, when using standard configuration flows that have elevated units, the elevated process would not operate properly. This came down to a case sensitive bool conversion that would cause the validation flow to not properly read from the alias file.
The resolution is to make that bool conversion case insensitive.
🔗 References
Fixes #6304
🔍 Validation
Added a new test targeting this flow with a test hook to force it without needing to pump the discovery state machine.
Microsoft Reviewers: Open in CodeFlow