Add support for Union properties - #102
Merged
Merged
Conversation
1 task
mikee47
force-pushed
the
feature/union-props
branch
9 times, most recently
from
August 26, 2026 15:26
6d33369 to
842edbb
Compare
mikee47
force-pushed
the
feature/union-props
branch
4 times, most recently
from
August 28, 2026 06:23
f5655cf to
956480f
Compare
…e `DefaultData` for unions
Fix `getDataPtr` offset calculation
mikee47
force-pushed
the
feature/union-props
branch
from
August 28, 2026 07:45
956480f to
71a6e34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, unions (defined using
oneOf) may only contain objects. This PR rectifies that to allow a mix of both Objects and Properties. It also enables selection of the default union tag via the standarddefaultproperty.In addition, the default union tag may be specified in the schema via the standard
defaultproperty. (Currently the default is the first field and cannot be changed.)The code generator now also checks for duplicate objects/property names within a union and reports an error.
TODO:
toXXX()configures the appropriate default value. Currently only the union default is applied.