fix/set object type correctly - #106
Merged
Merged
Conversation
Owner
|
Good catch. It would be nice if there were a way to get the compiler to catch this sort of problem! |
Contributor
Author
|
indeed, I assume the segfault is a blessing in this case, it could also have happened silently if the written datatype had fit into the memory location. |
Owner
|
NB. If you build with |
mikee47
pushed a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the rgbww sample app used
auto req = update.toColor().params.toRaw();and similar callsto set the params enum to the correct type.
However, in the chained call, that was only applied to a temporary object, leading to a segfault when writing to it.
this fix changes this as follows, creating a real object and setting it's type correctly.