Skip to content

chore(ui): Remove the stale bun lockfile and add the vuln scan - #359

Merged
yahyafakhroji merged 3 commits into
mainfrom
fix/dependency-vulnerabilities
Nov 18, 2026
Merged

yahyafakhroji merged 3 commits into
mainfrom
fix/dependency-vulnerabilities

Conversation

@yahyafakhroji

Copy link
Copy Markdown
Contributor

Problem
ui/bun.lock last changed in March, after the UI moved to pnpm, and it listed 17 vulnerable packages that nothing installs. The real pnpm lockfile resolves React Router 6.30.6 and turbo-stream 2.4.1 through Remix 2, plus minimatch and glob, all with fixes only outside their parents' ranges. No CI job scanned the lockfiles.

Solution
ui/bun.lock goes away. osv-scanner.toml ignores five advisories until 2027-02-28. The React Router and turbo-stream fixes need ui/example migrated off Remix 2, and minimatch and glob are build-time dependencies of @remix-run/dev. ui/example ships as the activity-ui container on remix-serve, so the React Router exposure stays real until that migration, although the published @datum-cloud/activity-ui package depends on neither. A new workflow runs the shared datum-cloud/actions vuln-scan on pull requests, pushes to main and every Monday.

The UI type-checks and builds, and osv-scanner and govulncheck report no unignored issues. Once OSV ingests the 18 Nov React Router v6 advisories (GHSA-x8j4-g9rr-8j87, GHSA-7m2v-44vx-v55w), the scan will fail until someone adds them to the ignore file or the migration lands.

The ui package uses pnpm (packageManager, Dockerfile, Taskfile and
the npm publish workflow). bun.lock was last touched in March and
only produced scanner findings for versions pnpm no longer resolves.
Remix 2 pins react-router 6.x and turbo-stream 2.x, and the dev-only
minimatch and glob fixes need majors their parents reject. Each ignore
expires 2027-02-28 and records why.
Runs the shared datum-cloud vuln-scan on pull requests, pushes to
main, weekly, and on demand. It reads the root osv-scanner.toml.
@yahyafakhroji
yahyafakhroji requested a review from a team as a code owner November 18, 2026 22:52
@yahyafakhroji
yahyafakhroji merged commit 1ce6c58 into main Nov 18, 2026
14 checks passed
@yahyafakhroji
yahyafakhroji deleted the fix/dependency-vulnerabilities branch November 18, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants