Repository navigation
feat: define feedback.miloapis.com v1alpha1 types - #16
Closed
mattdjenkinson wants to merge 1 commit into
Closed
mattdjenkinson wants to merge 1 commit into
mattdjenkinson wants to merge 1 commit into
Conversation
Types for every resource in the design: Post, PostQuery, Vote, Subscription, Submission (with review and to-security-report subresources), SecurityReport, SecurityAcknowledgement, Release, ChangelogEntry and AttachmentUpload. - Regenerated deepcopy, clientset and OpenAPI. Enums are marked so clients get allowed values - Field selectors declared per kind in FieldSelectors - A sample for every kind, decoded strictly in tests - Tests that every kind has a GVK extension and every ref resolves, so server-side apply works once storage lands Departs from the design YAML in two places: - The post status field is state, not status.status - Attachments are a create-only AttachmentUpload resource, since a subresource needs its parent to exist first Closes #2.
mattdjenkinson
requested review from
0xmc,
JoseSzycho,
kevwilliams,
savme and
scotwells
November 11, 2026 10:17
This was referenced Nov 11, 2026
Closed
Contributor
Author
|
Closing: the design moved from an aggregated apiserver with Postgres to CRDs in Milo with an operator (datum-cloud/enhancements#925). The CRD version starts in #32. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2. Stacked on #15, so merge that first and this PR will retarget to
main.Adds
feedback.miloapis.com/v1alpha1types for every resource in the design. The types are registered with the scheme but nothing serves them yet; storage comes in #3 onwards.Postfeedback-sync; staff onlyspec.hiddenPostQueryVote,SubscriptionSubmissionReviewandToSecurityReportSubmissionReview,SubmissionToSecurityReportSecurityReportSecurityAcknowledgementRelease,ChangelogEntryfeedback-syncAttachmentUploadChanges from the design YAML
state. In the design it wasstatus.status, and the enum type would have collided with thePostStatusstruct.PostQuery's filter and facets usestateto match.AttachmentUploadresource. The design put them onsubmissions/attachmentsandsecurityreports/attachments, but a subresource needs its parent object to exist first, and clients upload before they create the submission. An upload has apurpose(SubmissionorSecurityReport), so security report files can go under their own prefix. The file arrives as base64data, so the apiserver's request size limit applies; Submission #8 sets the actual limits.Vote.status.createdAtis dropped. It duplicatedmetadata.creationTimestamp.ChangelogEntry.status.issueRefsis new. It lists every issue referenced in the body. Delivery tracking needs it to mark a post part-shipped when a changelog links one of its work items rather than the post.SubmissionTriage.likelySecurityIssueis new. The design says triage flags likely security issues but had no field for it.Not included:
FeedbackProfilefor the public-votes opt-in. The design only needs it if Milo'sUserPreferencecan't carry the setting, which is still to check.Also in this PR
+enum, so the schema lists their allowed values.FieldSelectorsdeclares the field selectors each kind supports. The registries will expose the same fields.config/sampleshas an example for every kind.Testing
go test ./...passes. The new tests check:x-kubernetes-group-version-kindextension, and every$refresolves to a published definition.