Repository navigation
feat: security reports, acknowledgements and moving submissions - #39
Open
mattdjenkinson wants to merge 4 commits into
Open
mattdjenkinson wants to merge 4 commits into
mattdjenkinson wants to merge 4 commits into
Conversation
3 of 4 tasks
New reports start in Received with a timeline entry and get a private SecurityReportTriage; attachments are copied under the report and deleted with it. Fixed or disclosed reports with public credit get a SecurityAcknowledgement. MoveToSecurity decisions create a report owned by the submitter from the submission, copy its files and delete it. Admission checks credit links and external reporters' contact details, keeps the timeline append-only, and adds a timeline entry for a phase change that lacks one.
mattdjenkinson
force-pushed
the
feat/crd-security
branch
from
November 17, 2026 20:53
7f641b8 to
34c02ac
Compare
|
Please fix before merging: moving a submission to security deletes the original whenever any security report already has the same name ( Only delete after verifying the destination belongs to this exact source submission and owner, including the |
The move-to-security reconciler deleted the submission whenever any security report had the target name, so a name collision could lose the submission and its files. The moved report is now named <submission>-<submission UID> and annotated with the submission's name and UID. The reconciler reads the report back on both the create and AlreadyExists paths and checks name, UID and owner before it copies the attachments and deletes the submission (with a UID precondition). On a mismatch it keeps the submission and its files, sets Applied=False/ReportNameTaken on the review, and retries when a report is deleted. It also waits for the submission's files to be copied under it before moving. The security report webhook lets only the operator set the moved-from annotations and refuses changes to them.
Contributor
Author
|
Fixed in 347cd3a.
|
scotwells
approved these changes
Nov 18, 2026
scotwells
previously approved these changes
Nov 18, 2026
This was referenced Nov 18, 2026
Open
mattdjenkinson
dismissed
scotwells’s stale review
November 18, 2026 21:05
The base branch was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9. Closes #8, after #37 and #38. Stacked on #38.
Security reports as CRDs: what the Postgres version did in its storage strategy and its
to-security-reportsubresource, now done by admission webhooks and reconcilers.Admission
securityreport(validating; creates and status updates):spec.reporterwith an email or GitHub username, and the email must look like one.NotApplicableandDuplicateneed a reason, credit rewards need an amount, advisories need an https link, and CVSS vectors must be well-formed.securitytimeline(mutating; status updates): adds the entry when the Security Team changes the phase without one, as the old status strategy did.The schema already covers text limits, enums and an immutable spec.
Reconcilers
security-report:Receivedand its first timeline entry.SecurityReportTriage, owned by the report, for private notes. This replacesstatus.internal.Duplicateno longer requiresduplicateOf, because that field lives on the triage object now.security-reports/<name>/, with the attachments finalizer, as for submissions.FixedorDisclosedand the reporter chose public credit, it keeps aSecurityAcknowledgementwith the name, link, the month of the first fixed or disclosed entry, and the severity. It's deleted if that stops being true.move-to-securitycarries outMoveToSecurityreview decisions:spec.affectedfrom the review.Milo RBAC
The operator can now create
securityreporttriages.Not in this PR
security@datum.netand to the reporter on every phase change. Those come with the notifications work.Tests
javascript:credit link are refused.Receivedand gets its triage object;Fixedwith public credit creates the acknowledgement with month2026-10and severity;task test,go test -race -count=2on the reconciler and webhook tests,go vet ./..., andtask generatewith no diff