Repository navigation
feat: index posts, releases and changelog entries in search - #41
Open
mattdjenkinson wants to merge 8 commits into
Open
mattdjenkinson wants to merge 8 commits into
mattdjenkinson wants to merge 8 commits into
Conversation
ResourceIndexPolicies for Post, Release and ChangelogEntry make their text searchable through Milo's search service, which clients use for keyword search and similar posts. Hidden posts are left out, derived fields aren't indexed, and private kinds never are. hack/search-lag.sh measures how long a change takes to reach the index.
mattdjenkinson
force-pushed
the
feat/crd-activity
branch
from
November 17, 2026 20:53
fe9b756 to
e78022e
Compare
mattdjenkinson
force-pushed
the
feat/crd-search
branch
from
November 17, 2026 20:53
229f904 to
79bc6ba
Compare
|
Please address before merging:
|
…nt search scope
search-lag.sh records the post's original spec.hidden and restores exactly
that on every exit once it has changed it; it refuses hidden or unindexed
posts and tells failed queries apart from misses. The Post CRD defaults
spec to {} because search's indexer can't evaluate spec.hidden on a post
with no spec. Posts are indexed as platform documents, so only
platform-root queries find them; the README says who can search and with
what access, and hack/search-scope.sh checks it against an environment.
Add task e2e:up, e2e:test and e2e:down, following milo-os/billing: a test-infra kind cluster, Milo built and deployed from MILO_DIR, and feedback installed in that Milo with the operator, feedback-uploads and MinIO in the cluster (config/overlays/e2e). The operator and feedback-uploads authenticate to Milo with static tokens for their production usernames, so the admission webhooks' identity checks and config/milo/rbac are exercised as they are. test-infra's Milo uses RBAC, so the IAM roles are granted as equivalent ClusterRoles (hack/e2e/iam-rbac.sh). Chainsaw tests cover votes and owner rules, hidden posts, merge chains, submissions and review decisions, the submission rate limit, attachments through feedback-uploads and MinIO, moving submissions to security, and operator readiness.
2 tasks done
Contributor
Author
|
scotwells
approved these changes
Nov 18, 2026
test: end-to-end tests in kind against a real Milo
scotwells
approved these changes
Nov 18, 2026
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12. Stacked on #40. The issue stays open until the index lag is measured in staging.
Ports the search index policies from the closed Postgres PR (#31). With CRDs they matter more: there's no PostQuery, so clients run a
ResourceSearchQueryboth for keyword search and for "similar posts" while someone writes feedback.config/milo/searchhas aResourceIndexPolicyforPost,ReleaseandChangelogEntry.votes,trendingScore,delivery), since they'd go stale.RequestResponse. Without it, nothing is indexed.hack/search-lag.sh <post>: hides a visible post, waits for search to drop it, then unhides it and times how long until search finds it again. Run it against staging (Deploy to staging #13), then close Search integration #12 with the numbers.Tests
test/config/search_test.go, ported:kustomize buildof the Milo components renders 3 policies;bash -npasses on the lag script.Also includes #42
#42 was merged into this branch, so this PR also brings in the kind end-to-end tests (
task e2e:up,task e2e:test,test/e2e/). They pass 8 of 8 on this branch.