Repository navigation
fix(deps): Build the collector on OpenTelemetry Go v1.47 - #278
Conversation
The OpenTelemetry Go v1.47.0 security fix (GHSA-q7gw-24fr-5p69) cannot land on its own: it pulls in the stable otel/log v1.47.0, and collector v0.157.0's otelzap bridge no longer compiles against it, so the otelcol image build fails. Moving the collector to v0.165.0, which is built on OTel v1.47.0, lets the security bump and the image build land together. Key features/changes: - Move every builder-config component and the OCB builder to v0.165.0; k8sattributesprocessor is now on its stable line, v1.4.0, which is the same contrib commit as v0.165.0 - Move natsreceiver, natsexporter and unbatchprocessor to collector v1.71.0 / v0.165.0 so OCB resolves one consistent set - Bump otel, otel/sdk, otel/trace and otel/metric to v1.47.0 and testify to v1.12.1 in operator, queryapi and clickhouse-migrate, as #274 and #275 propose Fixes #277
|
Two reviews agree, and CI is green on 2bfe44b, including the otelcol image for both architectures and the operator suite. The correctness review built the collector at v0.165.0 and ran The blast-radius review found that merging rolls the new bundle to the staging o11y sink and the staging edge labs within about a minute. Production stays on the v0.6.10 pin until a release and an infra pin PR. After merge, #274, #275, #276 and the abandoned #250 can close. #273 (x/crypto) still needs to land and will want a rebase. |
andrewb3000
left a comment
There was a problem hiding this comment.
Non-blocking
config/collectors/gateway-collector.yaml:86: No CI job runs the gateway, node-agent and sink configs against the new binary, so a setting removed between v0.157 and v0.165 would only show as a crashloop after release. Runotelcol validateon all three configs, or watch staging, before the next release tag.
Checked
otelcol/builder-config.yaml:28: k8sattributesprocessor is pinned at v1.4.0 while the other contrib components use v0.165.0. The version does exist: publish.yaml builds the otelcol image on PRs for amd64 and arm64, and that build passed.operator/go.mod:80: In operator and queryapi, otel/exporters/otlp/otlptrace* stays at v1.45.0 while the otel core moves to v1.47.0. Both modules still build and their tests pass, so this is fine, but Renovate will likely open follow-up PRs for those exporters.
Summary
The OpenTelemetry Go v1.47.0 security fix for GHSA-q7gw-24fr-5p69 cannot merge, because the collector image stops building with it.
The fix pulls in the stable OpenTelemetry log API, and the collector at v0.157.0 still bundles a logging bridge written against the older one.
This moves the collector build and every component to v0.165.0, which is built on OpenTelemetry Go v1.47.0, and carries the v1.47.0 bumps from #274 and #275 in the same change.
Once it merges, #274, #275 and #276 have nothing left to add.
Test plan
Fixes #277