Repository navigation
MOBILE-389: Remove ids for removed providers - #801
Merged
Merged
Conversation
enotniy
requested review from
sergeysozinov
and
a balanced review from Copilot
October 9, 2026 08:16
There was a problem hiding this comment.
🟡 Changes recommended
An explicitly empty provider configuration is treated as unknown, leaving stale IDs intact.
1 open finding
What changed in this PR
Removes stored tracking IDs when push providers are no longer configured.
Changes:
- Tracks configured provider ID types.
- Filters stale IDs and adds resolver tests.
| File | Description |
|---|---|
Mindbox.kt |
Exposes configured tracking ID types. |
TrackingIdsResolver.kt |
Removes IDs for unconfigured providers. |
TrackingIdsResolverTest.kt |
Tests provider-removal scenarios. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sergeysozinov
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-389