Remove unused --layout-aside-background-color interface token#45
Merged
Conversation
The token was declared in settings.ui.css but no rule in the framework, the docs site, or the vendored mock sites ever consumed it. Regenerated dist/ and noted the removal in the 1.0.0 Changed section. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for mcssdev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…on-9e7f8a # Conflicts: # dist/css/settings.ui.css # dist/mcss.css # dist/mcss.min.css # src/styles/framework/settings.ui.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--layout-aside-background-color: var(--base-100)declaration from the GLOBAL section ofsrc/styles/framework/settings.ui.css.dist/(npm run build:css) so the committed build stays in sync.CHANGELOG.mdunder 1.0.0's Changed section.Why
The token was declared but never consumed: a grep across
src/anddist/finds only the declaration, novar(--layout-aside-background-color)reads. The aside rules inglobal.layout.cssset no background at all, so the token advertised a customization hook that did nothing.Reviewer notes
~/code/mocks(eastman, seagull, spiral) vendorsettings.ui.cssand carry the same inert declaration; none override or consume it, so removal changes nothing for them. Their vendored copies will pick up the deletion next time they syncdist/css/..layout-sidebar: wiring it in would have painted--base-100behind every sidebar aside, a visual change to the shipped design right before v1.--layout-aside-widthis untouched.🤖 Generated with Claude Code