feat(MarkdownEditor): support custom toolbar tools - #2781
Open
TimAufdemKampe wants to merge 8 commits into
Open
Conversation
TimAufdemKampe
requested review from
Jan-Eimertenbrink,
Lisa18289,
ins0,
maaaathis and
mfal
as code owners
August 5, 2026 06:55
Contributor
Coverage Report for ./packages/components/
File Coverage
|
||||||||||||||||||||||||||||||||||||||
TimAufdemKampe
force-pushed
the
2538-custom-buttons-in-markdowneditor
branch
2 times, most recently
from
August 5, 2026 07:30
64a47a3 to
b7f46bc
Compare
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
TimAufdemKampe
force-pushed
the
2538-custom-buttons-in-markdowneditor
branch
from
August 5, 2026 07:49
b7f46bc to
2a22a78
Compare
Jan-Eimertenbrink
left a comment
Jan-Eimertenbrink
left a comment
Member
There was a problem hiding this comment.
Mir sind in der Doku schon mal ein paar kleinigkeiten aufgefallen. Technisch wird das am besten ein Dev reviewen. Mir ist noch aufgfallen, dass wir generell noch mal nach dem responsiven Verhalten der Komponente schauen müssen. Dazu mache ich aber ein extra issue
Lisa18289
reviewed
Aug 6, 2026
Member
|
unter remote-react-components sollte noch ein Screenshot Test ergänzt werden |
Lisa18289
reviewed
Aug 6, 2026
Lisa18289
reviewed
Aug 6, 2026
mfal
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
Co-authored-by: mfal <4696750+mfal@users.noreply.github.com>
Lisa18289
reviewed
Aug 10, 2026
| <MarkdownEditor rows={1} isDisabled> | ||
| <Label>Disabled</Label> | ||
| </MarkdownEditor> | ||
| <MarkdownEditor rows={1}> |
Member
There was a problem hiding this comment.
Der neue Test ist nicht sichtbar, da er nicht mehr in den viewport passt
Lisa18289
reviewed
Aug 10, 2026
|
|
||
| await preview.click(); | ||
|
|
||
| await testScreenshot("MarkdownEditor - preview"); |
Member
There was a problem hiding this comment.
Der Test zeigt eine unerwünschte Veränderung
Lisa18289
reviewed
Aug 10, 2026
Member
There was a problem hiding this comment.
der Screenshot kann weg, dafür haben wir ja die Screenshot Tests
…bled state ModeButton's internal Button unintentionally picked up the ambient toolbarActionsPropsContext isDisabled meant for custom toolbar buttons, disabling "Exit Preview" while in preview mode. Also split the new custom-toolbar-button visual test case into its own screenshot so it is not cropped by the fixed test viewport, and remove a stray vitest failure-artifact screenshot that was committed by mistake.
BenniEngel
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
Co-authored-by: BenniEngel <187296787+BenniEngel@users.noreply.github.com>
BenniEngel
added
the
update-screenshots
github-actions
Bot
removed
the
update-screenshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2538