Repository navigation
fix(skills): show the Next action marker in autopilot's handoff example #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| package mem | ||
|
|
||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
| "regexp" | ||
| "strings" | ||
| "testing" | ||
| ) | ||
|
|
||
| // quoted matches one single-quoted shell argument. | ||
| var quoted = regexp.MustCompile(`'([^']*)'`) | ||
|
|
||
| // exampleBody returns the handoff body a skill pipes into `dotf mem | ||
| // handoff-write`: the single-quoted printf arguments, one per line, ahead of the | ||
| // pipe into handoff-write. printf rather than a heredoc, because a heredoc's | ||
| // terminator breaks when the example sits indented inside a list item. | ||
| func exampleBody(t *testing.T, skill string) string { | ||
| t.Helper() | ||
| raw, err := os.ReadFile(filepath.Join("../../..", "harness", "skills", skill, "SKILL.md")) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| lines := strings.Split(string(raw), "\n") | ||
| for i, l := range lines { | ||
| if !strings.Contains(l, "printf '%s\\n'") || !strings.HasSuffix(strings.TrimSpace(l), "\\") { | ||
| continue | ||
| } | ||
| var body []string | ||
| for _, next := range lines[i+1:] { | ||
| for _, m := range quoted.FindAllStringSubmatch(next, -1) { | ||
| body = append(body, m[1]) | ||
| } | ||
| if strings.Contains(next, "dotf mem handoff-write") { | ||
| return strings.Join(body, "\n") + "\n" | ||
| } | ||
| } | ||
| } | ||
| t.Fatalf("%s SKILL.md has no `printf '%%s\\n' ... | dotf mem handoff-write` example", skill) | ||
| return "" | ||
| } | ||
|
|
||
| // A skill that tells an agent to pipe a body into handoff-write must show a body | ||
| // the writer accepts without warning: an example without `**Next action:**` is | ||
| // copied literally and writes a thread with no first step (#3110). | ||
| func TestAutopilotHandoffExampleCarriesNextAction(t *testing.T) { | ||
| body := exampleBody(t, "autopilot") | ||
| if w := ThreadWarnings(body); len(w) != 0 { | ||
| t.Errorf("the autopilot example body draws handoff-write warnings: %q", w) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Harness compliance
Class: REAL
SSOT (Standing Order #2, knowledge placement): the edited file is
generated: truefrom00_meta/skills/autopilot/SKILL.md, but only the render is changed here while the generator source stays stale. Concrete trace: any session that runsdotf harness refreshbefore the vault edit lands regenerates this file from the vault, restoringprintf '%s' "$BODY"and dropping the**Next action:**line — agents again learn the broken example, andTestAutopilotHandoffExampleCarriesNextActiongoes red in CI until someone re-applies the vault edit out of band. The PR discloses the pending vault edit, but as submitted the fix is one routine refresh away from being undone, anddotf harness checkcannot see the divergence.