feat(effects): Add keyword in dynamictext - #1291
Conversation
c45e94e to
dcc424f
Compare
|
How much more difficult would it be to create a variable offset that the user can define? Instead of a new keyword for a fixed offset of one frame it would allow for more flexibility if there was a parameter |
It's not really about difficulty. Its more about intuition and purpose. The dynamictext filter isn't exclusively about frame position. Would the offset parameter apply to "createdate" or "meta.media.0.codec.frame_rate"? If we want to make advanced frame/position counting features, I would rather put that in the count producer which is intended for that kind of thing. But i don't think a simple "+1" keyword confuses anything and it works with existing user interfaces (Shotcut, etc). |
The original request came from a user doing animation - so the core of what they really want is a genuine frame count to know which animation cel is being shown rather than a timecode. Which may also be interesting if we ever directly support variable frame rate video, where each frame can have its own variable duration? |
Having a frame number starting at 1 is useful in some animation workflows to have a more natural numbering of frames.
dcc424f to
567cc75
Compare
I'm probably missing some context. I don't know your animation workflow or why you are burning a frame number on your image. If there is a more complex workflow that this filter wasn't intended for, maybe we need a new filter. |
This is very handy in the pre-production phase. Usually animators use an animatic to help them work on their scenes, which is like an animated storyboard. It also helps productions with organizing audio stuff like speech, music, fx... |
|
The original request is very simple, and I think this PR solves the problem.
|
I think this is the key point of the original request in terms of what is needed from MLT for this use. They need to be able to perfectly track the actual frame/cel number being displayed, not the timecode divided by some arbitrary number of frames per second. |
Hi,
Having a frame number starting at 1 is useful in some animation workflows to have a more natural numbering of frames.
I basically just duplicated the code for the keyword "frame" and called it "frameo" ("o" for "offset").
Cheers,
Camille