Expose the Sleigh decode-cache reset safely - #19
Open
0verflowme wants to merge 1 commit into
Open
Conversation
A long-lived decoder needs to invalidate address-keyed parser state before bytes at an address can change. Retain the processor specification for the bridge reset and prove that a reused address observes the new instruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A long-lived Sleigh decoder must invalidate address-keyed parser state before bytes at an address can change. Otherwise a later disassembly can return the first instruction decoded there.
What
Add the fallible Sleigh::clear_cache API and retain the processor specification needed by the bridge reset. The regression decodes mov al, bl, clears the cache, then proves mov ah, bl at the same address observes the new bytes.
Depends on mnemonikr/libsla-sys#9.
Validation