Repository navigation
Conversation
Wrap Streamable HTTP and SSE transport HTTP clients so that, when the caller has not set CheckRedirect, redirects stay on the configured endpoint origin and do not change the HTTP method. Callers that supply their own CheckRedirect keep full control.
Contributor
|
Duplicate of #1440 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1429.
Streamable HTTP and SSE client transports currently use
http.DefaultClient(or a user-provided client) without a redirect policy, so a malicious or compromised endpoint can redirect MCP POSTs to another origin and leak session headers and JSON-RPC bodies.This change wraps the transport HTTP client when
CheckRedirectis unset:Endpoint(scheme + host).HTTPClient.CheckRedirect, use it as-is (no extra policy).Includes httptest-based tests for both transports (cross-origin blocked, same-origin redirect still works, custom
CheckRedirectrespected).go vet ./...andgo test ./...pass.