Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions auth/extauth/client_credentials.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,12 @@ func (h *ClientCredentialsHandler) Authorize(ctx context.Context, req *http.Requ

// Step 3: Exchange client credentials for an access token.
cfg := &clientcredentials.Config{
ClientID: creds.ClientID,
ClientSecret: creds.ClientSecretAuth.ClientSecret,
TokenURL: asm.TokenEndpoint,
Scopes: requestedScopes,
AuthStyle: selectTokenAuthMethod(asm.TokenEndpointAuthMethodsSupported),
ClientID: creds.ClientID,
ClientSecret: creds.ClientSecretAuth.ClientSecret,
TokenURL: asm.TokenEndpoint,
Scopes: requestedScopes,
AuthStyle: selectTokenAuthMethod(asm.TokenEndpointAuthMethodsSupported),
EndpointParams: url.Values{"resource": {prm.Resource}},
}

client := util.RestrictRedirects(httpClient)
Expand Down
31 changes: 31 additions & 0 deletions auth/extauth/client_credentials_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,37 @@ func TestClientCredentialsHandler_TokenRedirectToOtherOrigin(t *testing.T) {
}
}

// TestClientCredentialsHandler_TokenRequestIncludesResource verifies that the
// token request carries the resource parameter (RFC 8707).
func TestClientCredentialsHandler_TokenRequestIncludesResource(t *testing.T) {
// Without protected resource metadata, the resource server is also its
// own authorization server.
mux := http.NewServeMux()
server := httptest.NewServer(mux)
t.Cleanup(server.Close)
resourceURL := server.URL + "/resource"
mux.HandleFunc("/.well-known/oauth-authorization-server", func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
fmt.Fprintf(w, `{"issuer": %q, "token_endpoint": %q, "code_challenge_methods_supported": ["S256"]}`, server.URL, server.URL+"/token")
})
mux.HandleFunc("/token", func(w http.ResponseWriter, r *http.Request) {
if got := r.PostFormValue("resource"); got != resourceURL {
t.Errorf("token request resource = %q, want %q", got, resourceURL)
}
w.Header().Set("Content-Type", "application/json")
fmt.Fprint(w, `{"access_token": "token", "token_type": "Bearer"}`)
})

handler, err := NewClientCredentialsHandler(validClientCredentialsConfig())
if err != nil {
t.Fatal(err)
}
resp := &http.Response{StatusCode: http.StatusUnauthorized, Header: http.Header{}, Body: http.NoBody}
if err := handler.Authorize(t.Context(), httptest.NewRequest("GET", resourceURL, nil), resp); err != nil {
t.Fatalf("Authorize failed: %v", err)
}
}

func TestSelectTokenAuthMethod(t *testing.T) {
tests := []struct {
name string
Expand Down