Skip to content

docs(skills): allow full advisory details on the GHSA draft card - #2857

Merged
cliffhall merged 1 commit into
v2/mainfrom
v2/docs/2851-advisory-card-details
Oct 29, 2026
Merged

cliffhall merged 1 commit into
v2/mainfrom
v2/docs/2851-advisory-card-details

Conversation

@cliffhall

Copy link
Copy Markdown
Member

Closes #2851

Updates .claude/skills/security-advisory/SKILL.md:

  • Step 1, card body: replaces the "do not copy the vulnerability description onto the card" warning. The card may now carry the full analysis (description, reproduction, ownership verdict, affected lines, fix plan), since advisories have no comment API and the card is the only place the team can see it. States the premise (board Add tab and approval flow for server -> client sampling #28 access is managed) and what to do if board access is ever widened.
  • Step 1, score note: drops the "numbers and rubric names only" restriction. The score now takes the ordinary /issue-triage form, with a free-text justification per axis.
  • Publication rules unchanged: says explicitly that the public issue still waits for publication and that upstream findings still go through the upstream's private channel.
  • Step 6: new warning that converting the draft makes its body public, so review and trim it before converting.

Checked board-ops, issue-triage, AGENTS.md and docs/: none restates the old rule, so this is the only file changed. The skill's description is unchanged, so skills:eval was not re-run. verify:skills and npm run local:gate pass.

🤖 Generated with Claude Code

Board #28's audience is managed, so the card may carry the description,
repro, ownership verdict, affected lines and fix plan, and the Priority
score may carry its justification. States the premise so a widened board
audience has an obvious trigger to revisit, and warns that converting
the card in step 6 makes its body public.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the security-advisory workflow documentation update.

No open issues 🎉

What changed in this PR

Updates the security-advisory workflow documentation for #2851, allowing full analysis on private draft cards while preserving publication safeguards.

Changes:

  • Allows detailed advisory analysis on cards, provided board #28’s audience remains restricted to advisory handlers.
  • Permits free-text justifications alongside Priority scores.
  • Requires reviewing and trimming card bodies before conversion into public issues; publication timing and upstream private-reporting rules remain unchanged.
File Description
.claude/​skills/​security-advisory/​SKILL.md Revises card-content and scoring guidance and adds a pre-conversion disclosure warning.

Review effort: Balanced

@cliffhall

Copy link
Copy Markdown
Member Author

Copilot review loop closed: round 1 was clean (no inline comments, no headline issue, no suppressed comments), so per the stop rule no further round was requested. CI is green.

@cliffhall
cliffhall merged commit fee0315 into v2/main Oct 29, 2026
11 checks passed
@cliffhall
cliffhall deleted the v2/docs/2851-advisory-card-details branch October 29, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Issues and PRs for v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security-advisory skill: allow full advisory details on the GHSA draft card (board audience is managed)

2 participants