Repository navigation
[Docs] Use ToolCallException in the first tool example and add builder defaults - #554
Merged
chr-hertel merged 2 commits intoOct 8, 2026
Merged
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 7, 2026 23:11
chr-hertel
added
bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a minor, non-blocking documentation wording correction remains.
1 open finding
What changed in this PR
Updates server documentation to demonstrate client-visible tool errors and explain builder defaults and limits.
Changes:
- Uses
ToolCallExceptionin the calculator example. - Adds comments covering request-state keys, shim limits, and subscription lifetime.
| File | Description |
|---|---|
| docs/servers/tools.md | Updates example exception handling. |
| docs/run/server-builder.md | Documents configuration defaults and limits. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\InvalidArgumentException, which reaches the client only as "Error while executing tool" - nowToolCallException, like the error handling section recommends