Repository navigation
[Server] Bind Streamable HTTP sessions to the principal that opened them #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicolas-grekas
wants to merge
2
commits into
modelcontextprotocol:main
Choose a base branch
from
nicolas-grekas:session-principal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,6 +59,14 @@ class StreamableHttpTransport extends BaseTransport implements StatelessAwareTra | |
| public const SESSION_HEADER = 'Mcp-Session-Id'; | ||
| public const PROTOCOL_VERSION_HEADER = 'Mcp-Protocol-Version'; | ||
|
|
||
| /** | ||
| * PSR-7 request attribute holding a string that identifies the authenticated principal. | ||
| * | ||
| * A session only serves the principal that opened it. {@see Http\Middleware\AuthorizationMiddleware} | ||
| * sets it; an application authenticating requests itself sets it instead. | ||
| */ | ||
| public const PRINCIPAL_ATTRIBUTE = 'mcp.principal'; | ||
|
|
||
| /** | ||
| * Upper bound on the request body read for a POST, guarding against memory | ||
| * exhaustion from an oversized (or unbounded chunked) payload. | ||
|
|
@@ -207,10 +215,11 @@ protected function handleOptionsRequest(): ResponseInterface | |
| /** | ||
| * @param string $body the request body, already read and bounded by {@see self::handleRequest()} | ||
| * @param AccessToken|null $accessToken the token the request was authorized with, see {@see self::accessToken()} | ||
| * @param string|null $principal the principal the request was authenticated as, see {@see self::PRINCIPAL_ATTRIBUTE} | ||
| */ | ||
| protected function handlePostRequest(string $body, ?AccessToken $accessToken = null): ResponseInterface | ||
| protected function handlePostRequest(string $body, ?AccessToken $accessToken = null, ?string $principal = null): ResponseInterface | ||
| { | ||
| $this->handleMessage($body, $this->sessionId, $accessToken); | ||
| $this->handleMessage($body, $this->sessionId, $accessToken, $principal); | ||
|
|
||
| // Consume the immediate response exactly once, so a transport instance | ||
| // reused for a later POST does not replay it. | ||
|
|
@@ -236,13 +245,16 @@ protected function handlePostRequest(string $body, ?AccessToken $accessToken = n | |
| return $this->createJsonResponse(); | ||
| } | ||
|
|
||
| protected function handleDeleteRequest(): ResponseInterface | ||
| /** | ||
| * @param string|null $principal the principal the request was authenticated as, see {@see self::PRINCIPAL_ATTRIBUTE} | ||
| */ | ||
| protected function handleDeleteRequest(?string $principal = null): ResponseInterface | ||
| { | ||
| if (!$this->sessionId) { | ||
| return $this->createErrorResponse(Error::forInvalidRequest(self::SESSION_HEADER.' header is required.'), 400); | ||
| } | ||
|
|
||
| $this->handleSessionEnd($this->sessionId); | ||
| $this->handleSessionEnd($this->sessionId, $principal); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A |
||
|
|
||
| return $this->responseFactory->createResponse(200); | ||
| } | ||
|
|
@@ -512,9 +524,12 @@ private function handleHandshakeRequest(ServerRequestInterface $request, ?string | |
| return $this->createErrorResponse(Error::forInvalidRequest(self::SESSION_HEADER.' header must be a valid UUID.'), 400); | ||
| } | ||
|
|
||
| $principal = $request->getAttribute(self::PRINCIPAL_ATTRIBUTE); | ||
| $principal = \is_string($principal) && '' !== $principal ? $principal : null; | ||
|
|
||
| return match ($request->getMethod()) { | ||
| 'POST' => $this->handlePostRequest($body ?? '', self::accessToken($request)), | ||
| 'DELETE' => $this->handleDeleteRequest(), | ||
| 'POST' => $this->handlePostRequest($body ?? '', self::accessToken($request), $principal), | ||
| 'DELETE' => $this->handleDeleteRequest($principal), | ||
| default => $this->createErrorResponse(Error::forInvalidRequest('Method Not Allowed'), 405), | ||
| }; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 3c8363a: who opened the session is checked before waiting for the lock, and again under it. Another principal gets the 404 of an unknown session and can't keep the lock busy. An
initializesent with the session id leaked the same way (503 instead of 400), and it now never takes the lock.