Repository navigation
fix(model): accept URL elicitation requests without elicitationId - #1383
Open
Iamsohungrynow wants to merge 1 commit into
Open
Iamsohungrynow wants to merge 1 commit into
Iamsohungrynow wants to merge 1 commit into
Conversation
2026-07-28 removed elicitationId from URL mode elicitation requests, so the spec's own URL example failed to parse and an input_required result carrying it fell through to CustomResult. A missing id now reads as empty and an empty id isn't serialized; the field stays a String so the public API is unchanged.
github-actions
Bot
added
T-test
Contributor
|
@DaleSeo (assignment failed) is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026-07-28 dropped
elicitationIdfrom url mode elicitation, so aninput_requiredresult with the spec's url example fell through toCustomResultandcall_toolfailed. a missing id now reads as empty and isn't serialized, kept it aStringso the public api doesn't change