Skip to content

fix(core): reject Standard Schema failures with empty issues - #3100

Open
rwzdk wants to merge 3 commits into
modelcontextprotocol:mainfrom
rwzdk:fix/standard-schema-empty-issues
Open

rwzdk wants to merge 3 commits into
modelcontextprotocol:mainfrom
rwzdk:fix/standard-schema-empty-issues

Conversation

@rwzdk

@rwzdk rwzdk commented Oct 26, 2026 •

Copy link
Copy Markdown

Treat { issues: [] } as a Standard Schema validation failure instead of returning { success: true, data: undefined }. The spec distinguishes results by the presence of issues, not its length: https://standardschema.dev/schema.

The branch is rebased onto the current main, so it is no longer behind the base branch.

Adds sync/async regressions, transformed/undefined success controls, and a client/server patch changeset. This is a straightforward bug fix under CONTRIBUTING.md's small-fix exception; no API or dependency changes.

Validation on Windows, Node 24.21.0, pnpm 10.26.1:

  • The two new regressions fail on unchanged main and pass with the fix.
  • Core-internal: 1,840 passed; client: 1,076 passed; server: 671 passed, 3 skipped; integration: 444 passed.
  • Workspace build, typecheck and lint passed.
  • The full workspace test command is not green locally: codemod's directory-symlink test fails with EPERM; two stdio shutdown-escalation cases (2025-11-25 and 2026-07-28) time out waiting for the SIGTERM marker on Windows.

AI disclosure: Codex generated the investigation, implementation, tests and this description, executed the listed checks, and performed a separate agent review. No production incident or human review is claimed.

@rwzdk
rwzdk requested a review from a team as a code owner October 26, 2026 01:54
@changeset-bot

changeset-bot Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3f07d25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@modelcontextprotocol/client Patch
@modelcontextprotocol/server Patch
@modelcontextprotocol/codemod Patch
@modelcontextprotocol/core Patch
@modelcontextprotocol/server-legacy Patch
@modelcontextprotocol/core-internal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@3100

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@3100

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@3100

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@3100

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@3100

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@3100

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@3100

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@3100

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@3100

commit: 3f07d25

@claude claude Bot added the v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes label Oct 26, 2026
@rwzdk
rwzdk force-pushed the fix/standard-schema-empty-issues branch from 983bd36 to 14b093e Compare October 26, 2026 15:41
Comment thread packages/core-internal/src/util/standardSchema.ts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants