fix(session): report daemon health probe failures - #927
Open
samuela wants to merge 1 commit into
Open
Conversation
Contributor
|
PR author is not in the allowed authors list. |
|
@samuela is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
i had a peculiar instance today where /health took >500ms, resulting in a timeout when using the skill. proposing adding some logging here to increase observability |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hunk sessioncurrently collapses every/healthfailure tonull. If the port still accepts TCP connections, the CLI then reports that another process owns it—even when a legitimate Hunk daemon is merely slow or returned a diagnosable HTTP/payload error.This discards the evidence needed to distinguish a timeout, HTTP failure, malformed response, or transport error.
Change
readSessionBrokerHealthand booleanisSessionBrokerHealthycontractshunk sessionto failsession listcalls silentThe retry policy and 500 ms timeout are intentionally unchanged; this PR adds observability rather than changing daemon lifecycle behavior.
Validation
bun test src/session/broker/brokerLauncher.test.ts src/session/agent/commands.daemon.test.ts— 16 passedHUNK_TEST_SHARDS=1 bun run test— 3508 passed, 12 skipped, 0 failedbun run typecheckbun run lintbun run format:checkbun run deps:checkbun run changeset:statusTested on NixOS/Linux with Bun 1.3.13. The delayed-response timeout test is skipped on Windows because of the existing Bun loopback-abort limitation documented by the session probe tests.