Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lite_bootstrap/bootstrappers/faststream_bootstrapper.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import asyncio
import dataclasses
import json
import logging
Expand Down Expand Up @@ -104,10 +105,12 @@ async def check_health(_: object) -> "AsgiResponse":

async def _define_health_status(self) -> bool:
config = self.bootstrap_config
if not config.application or not config.application.broker:
if not config.application or not config.application.brokers:
return False

return await config.application.broker.ping(timeout=config.faststream_health_check_broker_timeout)
timeout = config.faststream_health_check_broker_timeout
results = await asyncio.gather(*(broker.ping(timeout=timeout) for broker in config.application.brokers))
return all(results)


@dataclasses.dataclass(kw_only=True)
Expand Down
43 changes: 43 additions & 0 deletions tests/test_faststream_bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,49 @@ async def test_faststream_health_check_uses_configured_broker_timeout(broker: Re
bootstrapper.teardown()


async def test_faststream_health_check_fails_when_second_broker_is_down(broker: RedisBroker) -> None:
second_broker = RedisBroker()
config = build_faststream_config(broker=broker)
config.application.add_broker(second_broker)
bootstrapper = FastStreamBootstrapper(bootstrap_config=config)
application = bootstrapper.bootstrap()
try:
with (
patch.object(broker, "ping", new=AsyncMock(return_value=True)),
patch.object(second_broker, "ping", new=AsyncMock(return_value=False)),
TestClient(app=application) as test_client,
):
response = test_client.get(config.health_checks_path)
assert response.status_code == status.HTTP_500_INTERNAL_SERVER_ERROR
assert response.text == "Service is unhealthy"
finally:
bootstrapper.teardown()


async def test_faststream_health_check_pings_every_broker(broker: RedisBroker) -> None:
expected_timeout = 3.0
second_broker = RedisBroker()
config = dataclasses.replace(
build_faststream_config(broker=broker),
faststream_health_check_broker_timeout=expected_timeout,
)
config.application.add_broker(second_broker)
bootstrapper = FastStreamBootstrapper(bootstrap_config=config)
application = bootstrapper.bootstrap()
try:
with (
patch.object(broker, "ping", new=AsyncMock(return_value=True)) as first_ping,
patch.object(second_broker, "ping", new=AsyncMock(return_value=True)) as second_ping,
TestClient(app=application) as test_client,
):
response = test_client.get(config.health_checks_path)
assert response.status_code == status.HTTP_200_OK
first_ping.assert_called_once_with(timeout=expected_timeout)
second_ping.assert_called_once_with(timeout=expected_timeout)
finally:
bootstrapper.teardown()


def test_faststream_opentelemetry_excluded_urls_in_built_set(broker: RedisBroker) -> None:
bootstrap_config = dataclasses.replace(
build_faststream_config(broker=broker),
Expand Down
Loading