fix: breaking threadmenu fixes.#3425
Open
lorenzo132 wants to merge 6 commits into
Open
Conversation
Member
|
I'll lump this in with v4.3.0 as well even though it wasn't included in our previous discussions |
StephenDaDev
added
changelog
martinbndr
previously approved these changes
Dec 23, 2025
lorenzo132
requested review from
StephenDaDev,
martinbndr and
sebkuip
and removed request for
Copilot
martinbndr
previously approved these changes
Dec 28, 2025
sebkuip
requested changes
May 13, 2026
StephenDaDev
added
the
changelog
Member
|
Added to changelog for 4.3.0 |
StephenDaDev
added a commit
that referenced
this pull request
May 13, 2026
sebkuip
previously approved these changes
Jun 14, 2026
sebkuip
left a comment
sebkuip
left a comment
Member
There was a problem hiding this comment.
After the changes requested have been resolved, this looks fine now.
StephenDaDev
previously approved these changes
Jun 15, 2026
StephenDaDev
left a comment
StephenDaDev
left a comment
Member
There was a problem hiding this comment.
Looks good and seems to function properly without error or sideeffects on test instance.
martinbndr
previously approved these changes
Jun 15, 2026
Replaces the claim plugin by fourjr to my claim plugin due to being fundamentally broken as of the current time. It has been created few support issues already that were not successfull to use the plugin.
This adds two commands for renaming snippets and aliases for easier name editing.
Improves the make_alias function.
This PR solves the following: - thread creation menu null pointer bugs - false cancelled cache entry - If a menu times out, and the user send multiiple messages in the meantime the user would not be able to create a new thread with previous code.
This resolves an issue introduced in: #3423 Autocloses would fail.
lorenzo132
force-pushed
the
users/lorenzo/breaking-threadmenu-fix
branch
from
6c23d29 to
2b9856d
Compare
lorenzo132
requested review from
StephenDaDev,
martinbndr and
sebkuip
and removed request for
martinbndr and
sebkuip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the following: