Skip to content

Fix deep link installation for mods containing + (plus sign) #6464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mfishma wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −2
Open

Fix deep link installation for mods containing + (plus sign) #6464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c26fc41
ffix: preserve literal '+' in deep link URI thru API call
mfishma Jun 22, 2026
818f5b8
chore: check for missing projects during installs
mfishma Jun 22, 2026
c54627e
chore: remove accidental test files and quote error ID
mfishma Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/app-frontend/src/providers/content-install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,11 @@ export function createContentInstall(opts: {
) {
const project: Labrinth.Projects.v2.Project = await get_project(projectId, 'must_revalidate')

if (!project) {
opts.handleError(`Project not found: '${projectId}'`)
return
}

if (project.project_type === 'modpack') {
const version = versionId ?? project.versions[project.versions.length - 1]
const packs = await list()
Expand Down
9 changes: 7 additions & 2 deletions packages/app-lib/src/state/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,8 +1102,13 @@ impl CachedEntry {
.collect::<Vec<_>>()
.chunks(MAX_REQUEST_SIZE)
.map(|chunk| {
serde_json::to_string(&chunk)
.map(|keys| format!("{api_url}{url}{keys}"))
serde_json::to_string(&chunk).map(|keys| {
format!(
"{api_url}{url}{}",
url::form_urlencoded::byte_serialize(keys.as_bytes())
.collect::<String>()
)
})
})
.collect::<Result<Vec<_>, _>>()?;

Expand Down