Repository navigation
Conversation
- GitHub Actions workflow: npm ci, compile, lint, tests under xvfb with coverage, 85% line threshold, coverage artifact upload - Switch to @vscode/test-cli (coverage from the extension host) - Unit tests for format mapping / load commands; integration tests for all file/folder/start command paths - Extract format mapping into src/formats.ts, fixing .ent/.brk/.mcif/ .bcif/.sd format handling and escaping injected IDs/URLs - Fix panel dispose losing `this`; ignore cancelled accession input - Add missing eslint config - Includes pending molstar 4.8.0 / TypeScript 5 upgrade and file handling improvements from the molstar_4.8.0 branch Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.yml): on pushes tomainand on PRs it runsnpm ci, compiles, lints, runs the tests underxvfb-runwith coverage, fails below 85% line coverage, and uploads the coverage report.@vscode/test-cliso coverage is measured inside the extension host. This replaces the hand-rolledrunTest.tsandsuite/index.ts.activateFromFiles(single file, multi-select, nothing selected),activateFromFolder, andstart(PDB ID, UniProt ID, cancelled input).Bug fixes
.ent,.brk,.mcif,.bcifand.sdfiles were passed to Mol* under formats it doesn't recognise. The mapping now lives insrc/formats.ts.JSON.stringifybefore being written into the webview script.onDidDisposelostthis.startinput box no longer tries to load AlphaFold entry"undefined".npm run lintruns again.Also included
This branch also contains the pending molstar 4.8.0 / TypeScript 5 upgrade and the file-handling improvements from
molstar_4.8.0, because the new tests depend on that behaviour.Test plan
npm ci && npm run test:coverageon a clean checkout (macOS, VS Code 1.144): 32 passing, 87% lines🤖 Generated with Claude Code