Repository navigation
test(account): passkey method.add takes its approval at the finish, naming the new credential id - #196
Merged
Conversation
… at the finish, naming the new credential id Register options need no approval. POST /v1/account/methods refuses a finish without the approval (428) and one whose approval names another credential (403). The contract's PasskeyProof states the order. The software authenticator moves to the shared test helpers.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirms the order the iOS lane uses to add a passkey sign-in method, with a test, and states it in the contract.
POST /v1/auth/passkey/options(mode register) needs the session only, no approval.POST /v1/account/methodswithproof: {challenge_id, response}andX-OE-Approval. The approval'smethod.addparams name{type: passkey, subject}, wheresubjectis the new credential id as inresponse.id.account/test/methods.test.ts): a finish without the approval is 428approval_required; with an approval naming another credential, 403approval_invalid; with the right one, 201 and the stored subject is that credential id. It fails if the subject binding is removed (checked by reverting it: 201 instead of 403).account/openapi.yamlPasskeyProofdescribes the order, the 300 s window and why the response never goes to/v1/auth/passkey/verify.passkey.test.tstotest/helpers.tsso both tests use one copy.No server behavior changes. account: 28 files, 195 tests;
scripts/verify.shgreen in the pre-push hook.