Repository navigation
Conversation
The localStorage cap was hardcoded at 2048 raw bytes and handled separately in Chromium and Safari. Move it to the app layer as a configurable char limit (0 = unlimited) for local and session storage.
Add --max-storage-value to restore (the truncation hint named a flag it lacked), cap values in collector.Add instead of after the whole extraction, and reject a negative limit instead of silently unlimiting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #238 — configurable localStorage/sessionStorage value size limit.
What
--max-storage-valueondumpandrestore(default2048,0= unlimited, negative rejected).>=).Behaviour change
Firefox localStorage and Chromium sessionStorage, previously uncapped, now follow the same 2048-char default.
Follow-ups (not in this PR)
base64 export of binary values (also in the issue) needs byte-faithful raw-value plumbing. Refs #238, kept open.
Test
go test ./...green (goldens regenerated);golangci-lintclean; cross-compiles linux/windows/darwin.