Repository navigation
Work of trainee - #21
Merged
Merged
Conversation
This is a big change that @mohaTlg worked on it during his internship: 1. FASTTypeScript metamodel is regenerated again 2. All properties are added to the new generated metamodel. These properties are the same ones generated by TreeSitter, without checking if they exist already in FAST and how we can handle such dusplications... 3. Cardinality is taken into consideration because the properties were generated based on [this file](https://github.com/tree-sitter/tree-sitter-typescript/blob/master/typescript/src/node-types.json) 4. But also tests are generated automatically using the generator in the main Pharo-Tree-Sitter project: We took [the examples](https://github.com/tree-sitter/tree-sitter-typescript/tree/master/test/corpus) suggested by the main tree sitter typescript project, and Diallo created a mini parser to extract the examples from these files and generate tests with these examples. We wanted to make sure that we are covering the maximum number of classes and properties, so we decided to rely on what tree sitter community suggested... Cardinality is also taken into consideration in these tests. The main concept is to test the type of each node and the presence of its properties... This PR will be accepted in the WorkOfTrainee branch. We won't add it in the main branch unless we fully test it with the users of FASTTypeScript and make sure that it doesn't blow up their projects specially that everything was regenerated
Removed Pharo64 versions from the smalltalk matrix.
Updated project status and contribution guidelines in README.
Coverage Report for CI Build 37003656339Coverage increased (+60.1%) to 94.77%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.