fix(audio): advertise the Opus output sample rate#2404
Draft
kixelated wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2400.
Summary
The root cause was that the publisher advertised the original capture graph rate as an AudioDecoderConfig. Safari can realize 44100 Hz after a Bluetooth mute/unmute cycle, while its Opus decoder requires one of the native Opus output rates. The watcher support probe accepted 44100 but decoding closed the decoder, and the legacy loop continued calling decode on the closed instance.
Public API changes
Util.Opus.normalizeSampleRate(sampleRate?), an additive helper that selects 8, 12, 16, 24, or 48 kHz.Test plan
nix develop --command just js fixnix develop --command just js cinix develop --command just js test(Written by GPT-5)