fix(functional-tests): drop login_hint from the prompt=none grant test - #21359
Merged
Merged
Conversation
fxa-agent
Bot
force-pushed
the
agent-31f814
branch
from
September 30, 2026 20:32
7fef2f6 to
01ef907
Compare
LZoog
marked this pull request as ready for review
September 30, 2026 20:37
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is low risk; the remaining documentation nit is non-blocking.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Fixes the production prompt=none smoke test by relying on the existing signed-in session instead of login_hint.
Changes:
- Removes
login_hintfrom the test navigation. - Retains silent-grant and verification assertions.
| File | Description |
|---|---|
packages/functional-tests/tests/signin/unverifiedSession.spec.ts |
Updates the prompt=none flow to use the current session. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| const query = new URLSearchParams({ login_hint: credentials.email }); | ||
| await page.goto(`${target.relierUrl}/?${query.toString()}`); | ||
| await relier.goto(); |
vbudhram
approved these changes
Oct 1, 2026
Contributor
|
force push was to rebase with main |
Because: * The prompt=none silent grant test fails on every production smoke run with unauthorized_client. * A prompt=none request with login_hint needs the client on the prompt_none allowlist, and the production 123done client is not on it. This commit: * Opens 123done without login_hint before the prompt=none click, so the silent grant uses the current session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
prompt=nonesilent grant test inunverifiedSession.spec.tsfails on every production smoke run. 123done showsunauthorized_client.login_hint, fxa-settings requires the client to be on the prompt_none allowlist. The production 123done client is not on it. The stage client is.This pull request
login_hintbefore the test clicks the prompt=none button. The test signs in first, so the silent grant uses the current session and does not need the hint.Issue that this pull request solves
Closes:
Checklist
Put an
xin the boxes that applyHow to review (Optional)
unverifiedSession.spec.ts, theprompt=nonetest.oauthPromptNone.spec.tsstill coverslogin_hintchecks on local and stage.Screenshots (Optional)
n/a
Other information (Optional)
login_hintand passed without it.Email firstclick, before the changed line. CI runs this test on the local stack.