fix(auth-server): set SESSION_TOKEN_HANDLE_KEY in prod jwksUri config tests - #21360
Merged
Merged
Conversation
… tests Because: - The FXA-14056 cherry-pick added sessionTokenHandle.key to SECRET_SETTINGS, so the prod jwksUri tests failed on the secret check before the jwksUri check. This commit: - Sets SESSION_TOKEN_HANDLE_KEY in the GOOGLE/APPLE_AUTH_JWKS_URI prod config tests. (cherry picked from commit f07b134)
vbudhram
approved these changes
Oct 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments; the required secret is supplied in the production JWKS tests.
Review effort: Lite
Findings: None
What changed in this PR
Updates production JWKS URI configuration tests to provide the required session token handle secret.
Changes:
- Adds
SESSION_TOKEN_HANDLE_KEYto the Google/Apple production JWKS tests.
| File | Description |
|---|---|
packages/fxa-auth-server/config/index.spec.ts |
Supplies the required production secret in JWKS URI validation tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
GOOGLE/APPLE_AUTH_JWKS_URIconfig tests fail on main: FXA-14056 madesessionTokenHandle.keya required production secret, so they hit the secret check first.This pull request
SESSION_TOKEN_HANDLE_KEYin the two prod jwksUri config tests.Issue that this pull request solves
Closes: N/A
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Cherry-pick of f07b134 from
train-346, which isn't on main yet. Follows FXA-14056. No separate review: one-line test fix, andconfig/index.spec.tspasses 6/6 locally.