chore(settings): remove WebAuthnHelpersExample Storybook harness - #21365
Merged
Merged
Conversation
## Because - The `WebAuthnHelpersExample` page is a 1,298-line developer harness that only a Storybook story mounts. No route, test, or other module uses it. - The passkey owners agreed to remove it. ## This pull request - Removes `pages/WebAuthnHelpersExample/index.tsx`, `index.stories.tsx` and `fieldGuides.tsx` from `fxa-settings`. - Keeps `lib/passkeys/webauthn.ts` and `lib/base64url.ts` unchanged. Product code still uses all the exports that the page imported. ## Issue that this pull request solves Closes:
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified, and production passkey utilities remain unchanged.
Review effort: Lite
Findings: None
What changed in this PR
Removes the unused WebAuthn Storybook developer harness while preserving production passkey utilities.
Changes:
- Deletes the harness component and field guides.
- Deletes its Storybook story.
- Removes all remaining references.
| File | Description |
|---|---|
packages/fxa-settings/src/pages/WebAuthnHelpersExample/index.tsx |
Removes the harness UI. |
packages/fxa-settings/src/pages/WebAuthnHelpersExample/index.stories.tsx |
Removes the Storybook entry. |
packages/fxa-settings/src/pages/WebAuthnHelpersExample/fieldGuides.tsx |
Removes harness-only reference data and components. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vbudhram
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
WebAuthnHelpersExamplepage is a 1,298-line developer harness that only a Storybook story mounts. No route, test, or other module uses it.This pull request
pages/WebAuthnHelpersExample/index.tsx,index.stories.tsxandfieldGuides.tsxfromfxa-settings.lib/passkeys/webauthn.tsandlib/base64url.tsunchanged. Product code still uses all the exports that the page imported.Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-14649
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Pages/WebAuthnHelpersExamplegoes away. Engineers who used it to call the real Credentials API on localhost lose that tool.Screenshots (Optional)
None. The page had no route.
Other information (Optional)
Local results:
src/lib/passkeys/webauthn.test.ts: 36 passed.npx tsc --noEmitandeslintinfxa-settings: pass.git grep WebAuthnHelpersfinds no remaining reference.