Conversation
Because: - time-grunt is deprecated and only printed task timings in local Grunt runs. This commit: - Remove the time-grunt require from the content-server Gruntfile. - Drop the dependency; yarn.lock loses it and 8 packages only it used. Closes #FXA-4900
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Removes deprecated time-grunt usage and its unused dependency tree from the content server.
Changes:
- Removes the Gruntfile integration.
- Removes the direct dependency.
- Cleans corresponding
yarn.lockentries.
| File | Description |
|---|---|
yarn.lock |
Removes time-grunt and unused transitive dependencies. |
packages/fxa-content-server/package.json |
Removes the time-grunt dependency. |
packages/fxa-content-server/Gruntfile.js |
Removes timing plugin initialization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vbudhram
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
time-gruntis deprecated and only printed task timings in local content-server Grunt runs.This pull request
time-gruntfrom the content-server Gruntfile and dependencies;yarn.lockdrops it and 8 packages only it used.Issue that this pull request solves
Closes: FXA-4900
Checklist
Put an
xin the boxes that applyOther information
The String extraction test is expected to fail: it runs
main's code with this PR's packages, andmainstill loadstime-grunt. It will pass after merge.