Repository navigation
deps: pin url to v2.5.1 - #2240
Merged
Merged
Conversation
mozilla-central depends on `url` `v2.5.1`: https://searchfox.org/mozilla-central/rev/6050bf4eca89956c9d91bfd89fa59294ae32a689/Cargo.lock#6715-6725 The latest version of `url` is `v2.5.3`, which cargo automatically updates to, given that `Cargo.lock` is not checked in. `url` v0.2.5.3` introduced the `std` feature which breaks CI. mozilla#2219 enabled the feature, unbreaking CI, but breaking mozilla-central, given that mozilla-central still uses `url` `v2.5.1` which does not have the the `std` feature. This commit pins `url` to `v2.5.1` instead and removes the `std` feature.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2240 +/- ##
=======================================
Coverage 95.37% 95.37%
=======================================
Files 112 112
Lines 36569 36569
=======================================
Hits 34879 34879
Misses 1690 1690 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
mxinden
marked this pull request as ready for review
November 19, 2024 11:01
mxinden
requested review from
KershawChang,
larseggert and
martinthomson
as code owners
November 19, 2024 11:01
larseggert
approved these changes
Nov 19, 2024
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mozilla-central depends on
urlv2.5.1:https://searchfox.org/mozilla-central/rev/6050bf4eca89956c9d91bfd89fa59294ae32a689/Cargo.lock#6715-6725
The latest version of
urlisv2.5.3, which cargo automatically updates to, given thatCargo.lockis not checked in.urlv0.2.5.3introduced thestdfeature which breaks CI. https://github.com/mozilla/neqo/pull/2219 enabled the feature, unbreaking CI, but breaking mozilla-central, given that mozilla-central still usesurlwhich does not have the thestd` feature.This commit pins
urltov2.5.1instead and removes thestdfeature.Follow-up to #2239 (comment).