Conversation
tcashel
force-pushed
the
codex/rust-basedirs
branch
from
August 18, 2026 18:29
a07fe96 to
535a584
Compare
tcashel
force-pushed
the
codex/rust-basedirs
branch
from
August 18, 2026 20:17
535a584 to
9d3317f
Compare
tcashel
force-pushed
the
codex/rust-basedirs
branch
2 times, most recently
from
August 22, 2026 02:51
aac4073 to
c7a3c7f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2813 +/- ##
==========================================
- Coverage 73.71% 71.93% -1.78%
==========================================
Files 72 72
Lines 37932 38431 +499
==========================================
- Hits 27963 27647 -316
- Misses 9969 10784 +815 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 26, 2026
sylvestre
force-pushed
the
codex/rust-basedirs
branch
from
August 28, 2026 20:56
2b9a18f to
3528746
Compare
tcashel
marked this pull request as ready for review
August 29, 2026 01:18
Author
|
@sylvestre This is ready for review. #2814 and #2838 are stacked follow-ups. The new CI runs are also waiting for maintainer approval. Thanks! Please let me know if i'm doing something wrong, in code or in process! |
tcashel
force-pushed
the
codex/rust-basedirs
branch
from
September 17, 2026 19:12
08905ef to
b1fdda1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust builds of the same source in different worktrees currently get different cache keys. This makes Rust hashing honor
SCCACHE_BASEDIRS, using the longest matching root for source paths, remap sources, relevant environment values, and the working directory. The Rust cache-key version advances to 7.This is opt-in and changes cache keys, not embedded artifact paths. A cached crate using
env!("CARGO_MANIFEST_DIR")can retain the original checkout path. Tests cover cross-root reuse, source-change misses, argument framing, and Windows path forms.Rebased onto current upstream. Formatting, clippy, and the locked unit/integration suite pass on Apple silicon. CUDA cases skip locally; native Windows and CUDA validation are left to CI.
Request-scoped configuration follows in #2814. Related to #2595. Developed with OpenAI Codex.